Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flow param for Events API requests #587

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

arunshenoy99
Copy link
Member

Proposed changes

For the events API, since we are initializing the namespace at the beginning of onboarding, we will not be able to keep up with the change in the flow parameter, which is part of the URL. This parameter is not being used at all in the events API and is also unnecessary.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Jun 24, 2024
@arunshenoy99 arunshenoy99 requested a review from ajayadav09 June 24, 2024 11:53
@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jun 25, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 27, 2024
@arunshenoy99
Copy link
Member Author

PRESS0-1587

@arunshenoy99 arunshenoy99 merged commit 4ec7be5 into trunk Jun 27, 2024
3 of 4 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/old-flow-in-events branch June 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants