Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press0 1173 placeholder prompt input #559

Merged
merged 5 commits into from
May 15, 2024
Merged

Press0 1173 placeholder prompt input #559

merged 5 commits into from
May 15, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented May 6, 2024 •
edited
Loading

Proposed changes

Type of Change

https://jira.newfold.com/browse/PRESS0-1173

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ajayadav09 ajayadav09 self-assigned this May 6, 2024
@ajayadav09 ajayadav09 added the Code Review The PR is in Code Review label May 6, 2024
@ajayadav09 ajayadav09 requested a review from officiallygod May 6, 2024 16:57
officiallygod
officiallygod approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you pull in the trunk and ensure all the tests are running properly? Thanks.

@ajayadav09 ajayadav09 added QA This PR is in QA and removed Code Review The PR is in Code Review labels May 7, 2024
@ajayadav09 ajayadav09 merged commit bb6d299 into trunk May 15, 2024
3 of 4 checks passed
@arunshenoy99 arunshenoy99 deleted the PRESS0-1173-placeholder-prompt-input branch September 11, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees

@ajayadav09 ajayadav09

Labels
QA This PR is in QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajayadav09 @officiallygod @arunshenoy99