Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use Node 16 instead of 14 #484

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Update to use Node 16 instead of 14 #484

merged 2 commits into from
Feb 26, 2024

Conversation

wpscholar
Copy link
Member

@wpscholar wpscholar commented Feb 22, 2024

Update to use Node 16 instead of 14 (need to move to 20).

  • Adds an .nvmrc file to define Node version
  • Update GitHub workflow to use Node 16
  • Update package-lock.json file for Node 16

At a minimum, moving to Node 16 means we don't have to jump through hoops to run the build locally on M1 or M2 chips.

@wpscholar wpscholar added the dependencies Pull requests that update a dependency file label Feb 22, 2024
@wpscholar wpscholar self-assigned this Feb 22, 2024
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wpscholar, moving this for a round of QA before merging.

@arunshenoy99 arunshenoy99 added the QA This PR is in QA label Feb 23, 2024
@wpscholar wpscholar merged commit 49eb9e8 into trunk Feb 26, 2024
3 of 6 checks passed
@wpscholar wpscholar deleted the update/node branch February 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file QA This PR is in QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants