Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save continue dim UI #462

Merged
merged 14 commits into from
Feb 21, 2024
Merged

Save continue dim UI #462

merged 14 commits into from
Feb 21, 2024

Conversation

ajayadav09
Copy link
Contributor

add set pointer events to none for the body on Save and Continue

@officiallygod officiallygod added the Code Review The PR is in Code Review label Feb 13, 2024
arunshenoy99
arunshenoy99 reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the SPA lint workflow as well?

src/OnboardingSPA/steps/SiteGen/Editor/Header/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/steps/SiteGen/Editor/Header/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/steps/SiteGen/Editor/Header/stylesheet.scss Outdated Show resolved Hide resolved
src/OnboardingSPA/steps/SiteGen/Editor/Header/stylesheet.scss Outdated
z-index: 1;
}

.nfd-onboarding-header--sitegen__editor__end__save-button {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leverage SASS capabilities to break down --'s and __'s.

src/OnboardingSPA/steps/SiteGen/Editor/Header/stylesheet.scss Outdated Show resolved Hide resolved
src/OnboardingSPA/steps/SiteGen/Editor/Header/stylesheet.scss Outdated Show resolved Hide resolved
@ajayadav09
Copy link
Contributor Author

Screenshot 2024-02-15 at 5 05 36 PM Screenshot 2024-02-15 at 5 06 19 PM

Light mode and dark mode

@officiallygod officiallygod merged commit 3e1ac87 into trunk Feb 21, 2024
1 of 5 checks passed
@officiallygod officiallygod deleted the save-continue-dim-ui branch February 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod left review comments

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@ajayadav09 ajayadav09

Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajayadav09 @arunshenoy99 @officiallygod