-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Custom colors & fonts in the SiteGen customize sidebar is not preserved #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunshenoy99
reviewed
Feb 5, 2024
...rdingSPA/components/Sidebar/components/Customize/DesignColorsPanel/ColorPaletteIcon/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignColorsPanel/index.js
Show resolved
Hide resolved
src/OnboardingSPA/components/Sidebar/components/Customize/DesignFontsPanel/index.js
Show resolved
Hide resolved
arunshenoy99
approved these changes
Feb 6, 2024
arunshenoy99
added
the
Ready to merge
The Code Review and QA is done and it can be merged.
label
Feb 6, 2024
arunshenoy99
removed
the
Ready to merge
The Code Review and QA is done and it can be merged.
label
Feb 6, 2024
avneet-raj
added
Ready to merge
The Code Review and QA is done and it can be merged.
and removed
QA
This PR is in QA
labels
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to store the custom colors and custom fonts that have been applied by the user in the flow of SiteGen - Customization.