Site error page #445
Merged
Site error page #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule-onboarding into siteErrorPage
girish-lokapure
added
Code Review
arunshenoy99
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Upon clicking "Continue without AI," should we hide the Back button here?
I believe we will need to trigger the error state for the following:
- The flow data API calls.
- The site logo upload API call.
- The Facebook token API call.
- The Editor step customize data fetch API call.
- The Editor step global styles API call.
- The Editor step regenerate API call, in case it is critical enough to cause a white screen.
Let's also fix the lint? https://github.com/newfold-labs/wp-module-onboarding/actions/runs/7743344597/job/21114554218?pr=445
src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteGen/index.js
Outdated
Show resolved
Hide resolved
arunshenoy99
approved these changes
Feb 6, 2024
arunshenoy99
added
QA
|
Verified. Works as expected. |
The error page is now triggered for the following:
|
arunshenoy99
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onboarding data PR : newfold-labs/wp-module-onboarding-data#41