Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out header, content and footer for homepages #438

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Separate out header, content and footer for homepages #438

merged 3 commits into from
Jan 31, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Jan 30, 2024 •
edited
Loading

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Jan 30, 2024
officiallygod
officiallygod approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than that.

src/OnboardingSPA/steps/SiteGen/Editor/index.js Show resolved Hide resolved
@arunshenoy99 arunshenoy99 merged commit 9978f1a into enhance/ai-onboarding Jan 31, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the fix/double-header-footer branch January 31, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod