Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bug fixes reported #436

Merged
merged 15 commits into from
Feb 1, 2024
Merged

Conversation

ajayadav09
Copy link
Contributor

Refactored the center component and seperated the title component and the drop down component. It needed a local state to type in wothout re-rendering and added useEffect to update on the basis of that local state and change homepageTitle when content re-generates.

@officiallygod officiallygod added the Code Review The PR is in Code Review label Jan 30, 2024
Comment on lines 58 to 59
align-items: center;
justify-content: center;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-31 at 7 15 14 PM
Screenshot 2024-01-31 at 7 15 47 PM

Doesn't look right 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@officiallygod Have updated the code with by adding width to the parent container. The width will be different for devices.

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ajayadav09 ajayadav09 merged commit 5c0a76a into enhance/ai-onboarding Feb 1, 2024
1 check passed
@officiallygod officiallygod deleted the ui-bug-fixes-reported branch February 1, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants