Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with onboarding in AI branch #428

Merged

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Jan 25, 2024

No description provided.

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I started the Sitegen flow till the editor step and came back to fork to go through the old flow, Can you try this please ?

Screenshot 2024-01-25 at 10 59 05 AM Screenshot 2024-01-25 at 10 59 18 AM Screenshot 2024-01-25 at 10 59 26 AM

@officiallygod officiallygod added the Code Review The PR is in Code Review label Jan 30, 2024
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this once?

https://streamable.com/3jdkjn

Comment on lines +10 to 12
if ( handleClick ) {
handleClick();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ( handleClick ) {
handleClick();
}
if ( typeof handleClick === 'function' ) {
handleClick();
}

@@ -334,7 +334,9 @@ const SiteBuild = () => {

if ( lastChapter !== currentChapter ) {
if ( lastChapter ) {
currentData.data.chapters[ lastChapter ].completed = true;
if ( currentData.data.chapters[ lastChapter ] ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why currentData.data.chapters[ lastChapter ] does not exist in the first place?

@arunshenoy99 arunshenoy99 merged commit e11ee01 into enhance/ai-onboarding Feb 1, 2024
2 checks passed
@diwanshuster diwanshuster deleted the fix-press2-1589-onboarding-issue branch March 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants