Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Brand Plugin Cypress Tests GitHub Workflow in Module #401

Merged
merged 15 commits into from
Jan 11, 2024

Conversation

avneet-raj
Copy link
Contributor

Create a workflow to run Tests for Module in Brand Plugin

@avneet-raj avneet-raj self-assigned this Jan 5, 2024
@circlecube
Copy link
Member

Now that the postcss config file is no longer needed here the package updates are not required. I think they're a good idea to keep things updated, but if that is a hold up to merging this workflow in, we can lose the package updates completely. I'm happy to revert those if that would help.

@arunshenoy99
Copy link
Member

Now that the postcss config file is no longer needed here the package updates are not required. I think they're a good idea to keep things updated, but if that is a hold up to merging this workflow in, we can lose the package updates completely. I'm happy to revert those if that would help.

Thanks @circlecube. I agree that it's essential that we keep them updated. We'll test Onboarding with the new versions, and if nothing breaks, we'll merge this one along with the package updates, otherwise, we'll revert them and merge only the workflow.

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arunshenoy99 arunshenoy99 merged commit f28bba6 into trunk Jan 11, 2024
3 of 4 checks passed
@arunshenoy99 arunshenoy99 deleted the add-cypress-tests-workflow-in-module branch January 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants