Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dynamic BG #394

Merged
merged 10 commits into from
Jan 1, 2024
Merged

Fix Dynamic BG #394

merged 10 commits into from
Jan 1, 2024

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Dec 20, 2023
@officiallygod officiallygod self-assigned this Dec 20, 2023
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Dec 21, 2023
arunshenoy99
arunshenoy99 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Added minor non-blocking comments.

src/OnboardingSPA/components/NewfoldInterfaceSkeleton/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/NewfoldInterfaceSkeleton/index.js Outdated Show resolved Hide resolved
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels Dec 27, 2023
@arunshenoy99 arunshenoy99 merged commit a1fc1f2 into enhance/ai-onboarding Jan 1, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the fix-dynamic-bg branch January 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99