Api integration preview home page #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs/wp-module-onboarding into enhance/aio-design-previews # Conflicts: # src/OnboardingSPA/styles/app.scss
…dule-onboarding into enhance/aio-preview
…newfold-labs/wp-module-onboarding into api-integration-preview-home-page
…/wp-module-onboarding into enhance/aio-preview
…bs/wp-module-onboarding into api-integration-preview-home-page
…bs/wp-module-onboarding into api-integration-preview-home-page # Conflicts: # src/OnboardingSPA/styles/_branding.scss
officiallygod
changed the base branch from
enhance/ai-onboarding
to
demo/sitegen-mvp
officiallygod
changed the base branch from
demo/sitegen-mvp
to
enhance/ai-onboarding
Comment on lines
245
to
246
| $target_audience = get_option('nfd-ai-site-gen-targetaudience'); | ||
| $content_style = get_option('nfd-ai-site-gen-contenttones'); |
There was a problem hiding this comment.
I am pretty skeptical about this though.
Comment on lines
16
to
+19
| const { headers, headerActiveView, isHeaderEnabled, currentStep } = | ||
| useSelect( ( select ) => { | ||
| return { | ||
| currentStep: select( nfdOnboardingStore ).getCurrentStep(), |
There was a problem hiding this comment.
Maybe we can keep it in the same order i.e. var names and functions.
src/OnboardingSPA/components/LivePreview/SiteGenPreviewSelectableCard/index.js
Show resolved
Hide resolved
…bs/wp-module-onboarding into api-integration-preview-home-page
…bs/wp-module-onboarding into api-integration-preview-home-page
…bs/wp-module-onboarding into api-integration-preview-home-page
…bs/wp-module-onboarding into api-integration-preview-home-page
Comment on lines
208
to
216
| if ( ! $target_audience || ! $content_style ) { | ||
| return new \WP_Error( | ||
| 'nfd_onboarding_error', | ||
| __( 'Required data is missing.', 'wp-module-onboarding' ), | ||
| array( | ||
| 'status' => 400, | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
What if we add a code to send Error from our Service and catch it here, cause I believe here what if it gives an error from Press 3 API, that won't be null but still have an error and going forward will break things.
Comment on lines
244
to
255
| $target_audience = SiteGenService::instantiate_site_meta( $site_info, 'targetaudience', true ); | ||
| $content_style = SiteGenService::instantiate_site_meta( $site_info, 'contenttones', true ); | ||
|
|
||
| if ( ! $target_audience || ! $content_style ) { | ||
| return new \WP_Error( | ||
| 'nfd_onboarding_error', | ||
| __( 'Required data is missing.', 'wp-module-onboarding' ), | ||
| array( | ||
| 'status' => 400, | ||
| ) | ||
| ); | ||
| } |
Comment on lines
+61
to
+63
| const regenerate = () => { | ||
| // alert( 'regenerate' ); | ||
| }; |
There was a problem hiding this comment.
Is this supposed to be like this?
…bs/wp-module-onboarding into api-integration-preview-home-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
home page preview:
![Uploading Screenshot 2024-01-12 at 3.34.37 PM.png…]()