Basic Info GA Events API Automation #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avneet-raj
reviewed
Nov 21, 2023
| @@ -1,7 +1,7 @@ | |||
| // <reference types="Cypress" /> | |||
| import { | |||
| DrawerActivityForMenu, | |||
| DrawerClose | |||
| DrawerClose, | |||
There was a problem hiding this comment.
Removed it.
avneet-raj
reviewed
Nov 21, 2023
| 'platform', | ||
| 'platform', | ||
| ]; | ||
| const actual_values = [ '', title, desc, '', 'facebook', 'instagram' ]; |
There was a problem hiding this comment.
Are we checking only for 2 social links?
There was a problem hiding this comment.
Added for all
avneet-raj
reviewed
Nov 21, 2023
avneet-raj
reviewed
Nov 21, 2023
avneet-raj
reviewed
Nov 21, 2023
| '/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=wp-setup&_locale=user', | ||
| site_secondary_ecomm: | ||
| '/index.php?rest_route=%2Fnewfold-onboarding%2Fv1%2Fevents%2Fbatch&flow=ecommerce&_locale=user', | ||
| basic_info_batch: |
There was a problem hiding this comment.
Let's keep it as only 'basic_info' as we did for other pages
avneet-raj
reviewed
Nov 21, 2023
avneet-raj
approved these changes
Nov 29, 2023
avneet-raj
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRESS2-1368 : Cypress Test Events API: Basic Info