Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS2-1376 Add/sitegen socialmedia #366

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

girish-lokapure
Copy link
Contributor

@girish-lokapure girish-lokapure commented Nov 15, 2023

Screenshot Capture - 2023-11-15 - 18-37-03
Screenshot Capture - 2023-11-24 - 14-59-26

@girish-lokapure girish-lokapure changed the base branch from trunk to enhance/ai-onboarding November 15, 2023 13:09
@girish-lokapure girish-lokapure changed the base branch from enhance/ai-onboarding to add/sitegen-sitelogo November 15, 2023 13:09
Base automatically changed from add/sitegen-sitelogo to enhance/ai-onboarding November 18, 2023 08:16
@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Nov 18, 2023
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do merge the latest enhance/ai-onboarding branch as I think there are numerous changes.

src/OnboardingSPA/steps/SiteGen/SocialMedia/contents.js Outdated Show resolved Hide resolved
src/OnboardingSPA/steps/SiteGen/SocialMedia/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/styles/app.scss Outdated Show resolved Hide resolved
@diwanshuster diwanshuster self-requested a review November 24, 2023 08:44
Copy link
Contributor

@diwanshuster diwanshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check for mobile responsiveness as well?

@girish-lokapure
Copy link
Contributor Author

Can you check for mobile responsiveness as well?

done

Copy link
Contributor

@diwanshuster diwanshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@girish-lokapure girish-lokapure merged commit cf2170d into enhance/ai-onboarding Nov 28, 2023
1 check passed
@officiallygod officiallygod deleted the add/sitegen-socialmedia branch December 8, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR is a Work in Progress and not ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants