Fix failing cypress tests for design steps #364
Conversation
avneet-raj
added
Code Review
| @@ -90,7 +90,7 @@ describe( 'Theme Styles Menu and Preview', function () { | |||
| } ); | |||
| } ); | |||
|
|
|||
| it( 'Check for the selected theme in Drawer', () => { | |||
| it.skip( 'Check for the selected theme in Drawer', () => { | |||
There was a problem hiding this comment.
Why don't we get rid of these from here? The skipped ones in this file? as we have addressed them in the preview step?
| @@ -31,8 +23,8 @@ describe( 'Typography Step Test', function () { | |||
| ); | |||
| } ); | |||
|
|
|||
| it( 'Check to make sure sidebar opens, content is in place and close sidebar', () => { | |||
| CheckIntroPanel( '__design-typography', 'Typography' ); | |||
| it.skip( 'Check to make sure sidebar opens, content is in place and close sidebar', () => { | |||
There was a problem hiding this comment.
Why are we skipping this one?
It see that it is working in Colors.
There was a problem hiding this comment.
Yes, I have to remove it because when we directly go to the page using URL the sidebar isn't present.
have a look at this screenshot.
There was a problem hiding this comment.
Damn that should be a bug! 😕
There was a problem hiding this comment.
okay, I'll log a defect for this
There was a problem hiding this comment.
| @@ -49,15 +49,15 @@ describe( 'Header menu Page', function () { | |||
| } ); | |||
There was a problem hiding this comment.
In this I saw that now header menu takes time to load in the preview, should we also add a wait so that it gets rendered out as well?
There was a problem hiding this comment.
wait is already added, line 15
There was a problem hiding this comment.
I meant after clicking on a new header pattern it renders very slowly.
avneet-raj
added
Ready to merge
No description provided.