New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defensive checks for edge cases #328

Merged

arunshenoy99 merged 2 commits into trunk from hotfix/edge-case-basic-info

Oct 12, 2023

Member

arunshenoy99 commented Oct 10, 2023

When the GET settings API cannot read the corrupted wpseo_social option and fails, it tends to return a failed API response. We then attempt to read this false value in React, causing a white screen.
Point 1 leads to a false value being reported to the POST API, triggering an error in the debug log. While this doesn't result in a white screen, as a best practice, we have added a check anyway.

Both of these issues are incredibly rare but were prioritized for resolution. They are also challenging to replicate because of the rare nature.

arunshenoy99 added 2 commits

October 10, 2023 17:12


          Add defensive checks for edge case

b5daea4


          re-add permission check

c5665ed

arunshenoy99 requested review from diwanshuster and officiallygod

October 10, 2023 11:54

diwanshuster approved these changes

View reviewed changes

Contributor

diwanshuster left a comment

LGTM

officiallygod approved these changes

View reviewed changes

arunshenoy99 merged commit 51047f4 into trunk

3 checks passed

arunshenoy99 deleted the hotfix/edge-case-basic-info branch

October 12, 2023 07:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet