Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Coming Soon to Site Features #324

Merged
merged 12 commits into from
Oct 6, 2023
Merged

Add Coming Soon to Site Features #324

merged 12 commits into from
Oct 6, 2023

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Oct 3, 2023 •
edited
Loading

ss

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Oct 3, 2023
@officiallygod officiallygod self-assigned this Oct 3, 2023
@officiallygod
Improvements
b940afc 
Added Translations
Added API Requests
@officiallygod
Test
0d51563
@officiallygod
Test 2
499bc63
@officiallygod
Set Coming Soon on exit
416dfd0
@officiallygod
Additions
d254ffc 
Added a wait to make appearance subtle
Added a Specific Icon
@officiallygod
Renaming Things
cc7b8d0
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Oct 4, 2023
@officiallygod
Copy link
Member Author

Requires: newfold-labs/wp-module-onboarding-data#5

@officiallygod officiallygod requested a review from abhijitb October 6, 2023 02:52
abhijitb
abhijitb approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@abhijitb abhijitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@officiallygod officiallygod added QA This PR is in QA Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review QA This PR is in QA labels Oct 6, 2023
@officiallygod officiallygod merged commit 85e43fb into trunk Oct 6, 2023
1 check passed
@officiallygod officiallygod deleted the PRESS-2-1194-Add-coming-soon-to-Site-Features branch October 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 left review comments

@abhijitb abhijitb abhijitb approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@officiallygod @abhijitb @arunshenoy99 @0aveRyan