Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chapter Prioritization #303

Merged
merged 20 commits into from
Sep 26, 2023
Merged

Add Chapter Prioritization #303

merged 20 commits into from
Sep 26, 2023

Conversation

arunshenoy99
Copy link
Member

  1. Adds chapter prioritization based on experience level and top priority. Also adds support for mid-journey flows.
  2. Moves the namespace NewfoldLabs\WP\Module\Onboarding\Data\ and related services to Add data and services wp-module-onboarding-data#1
  3. Stores chapter information for the dashboard and handles deep-links into Onboarding just for that chapter.

Note: PHP Lint will fail on this PR until a 1.0.0 release is tagged on wp-module-onboarding-data.

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Sep 7, 2023
officiallygod
officiallygod reviewed Sep 8, 2023
View reviewed changes
src/OnboardingSPA/components/Drawer/DrawerPanel/DesignColors.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/DrawerPanel/Ecommerce/NavStoreInfo.js Show resolved Hide resolved
src/OnboardingSPA/components/Loaders/Chapter/Interstitial/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Loaders/Chapter/Interstitial/index.js Show resolved Hide resolved
src/OnboardingSPA/components/Loaders/Chapter/Interstitial/stylesheet.scss Show resolved Hide resolved
src/OnboardingSPA/components/Loaders/Chapter/Interstitial/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/data/models/PseudoStep.js Show resolved Hide resolved
src/OnboardingSPA/steps/GetStarted/SiteTypeSetup/PrimarySite/Sidebar/LearnMore/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Button/ButtonBlue/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/DrawerPanel/DesignHeaderMenu.js Outdated Show resolved Hide resolved
officiallygod
officiallygod approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Sep 11, 2023
@avneet-raj avneet-raj added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Sep 13, 2023
arunshenoy99
arunshenoy99 commented Sep 18, 2023
View reviewed changes
Copy link
Member Author

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Blocker] This should be merged after the 'Next Steps' feature is built to link back to Onboarding in the brand plugin dashboard.

arunshenoy99
arunshenoy99 commented Sep 26, 2023
View reviewed changes
Copy link
Member Author

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging the PR by disabling prioritization for now since this has other critical changes and keeps causing merge conflict given the number of files that have been modified. We can get a small PR in later to enable prioritization once the dashboard is ready with Next Steps.

@arunshenoy99 arunshenoy99 merged commit 91ed930 into trunk Sep 26, 2023
1 check passed
@arunshenoy99 arunshenoy99 deleted the enhance/chapter-prioritization branch September 26, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunshenoy99 @officiallygod @avneet-raj