Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Defensive checks in Patterns Data class #302

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Add Defensive checks in Patterns Data class #302

merged 3 commits into from
Sep 26, 2023

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Sep 7, 2023

Add Defensive checks in the Patterns Data class to avoid Undefined variable warning.

@mr-vara mr-vara changed the title Adds Defensive checks in Patterns Data class Add Defensive checks in Patterns Data class Sep 7, 2023
@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Sep 7, 2023
abhijitb
abhijitb reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@abhijitb abhijitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@avneet-raj avneet-raj added QA This PR is in QA and removed Code Review The PR is in Code Review labels Sep 20, 2023
arunshenoy99
arunshenoy99 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mr-vara, looks clean now!

@avneet-raj avneet-raj added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Sep 26, 2023
@mr-vara mr-vara merged commit bf853bb into trunk Sep 26, 2023
1 check passed
@arunshenoy99 arunshenoy99 deleted the fix/defensive-checks-patterns branch September 26, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

@abhijitb abhijitb abhijitb approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-vara @abhijitb @arunshenoy99 @avneet-raj