Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for translations in the module #299

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Add support for translations in the module #299

merged 3 commits into from
Sep 7, 2023

Conversation

arunshenoy99
Copy link
Member

No description provided.

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Aug 31, 2023
@circlecube circlecube mentioned this pull request Aug 31, 2023
Closed
officiallygod
officiallygod approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Sep 5, 2023
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Sep 7, 2023
@arunshenoy99 arunshenoy99 merged commit 40d9409 into trunk Sep 7, 2023
@arunshenoy99 arunshenoy99 deleted the enhance/add-translations-support branch September 7, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod