Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Safari ordering issue #291

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Fix Safari ordering issue #291

merged 8 commits into from
Sep 1, 2023

Conversation

officiallygod
Copy link
Member

Used Grids!

+ - +
| - |
+ - +

@officiallygod officiallygod added In Progress PR is a Work in Progress and not ready for review. Code Review The PR is in Code Review and removed In Progress PR is a Work in Progress and not ready for review. Code Review The PR is in Code Review labels Aug 18, 2023
@officiallygod officiallygod self-assigned this Aug 23, 2023
@officiallygod officiallygod added Code Review The PR is in Code Review and removed In Progress PR is a Work in Progress and not ready for review. labels Aug 24, 2023
arunshenoy99
arunshenoy99 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the React grid division as part of another story

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels Aug 25, 2023
@avneet-raj avneet-raj added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Aug 30, 2023
@officiallygod officiallygod added Code Review The PR is in Code Review and removed Ready to merge The Code Review and QA is done and it can be merged. labels Aug 30, 2023
@girish-lokapure
Copy link
Contributor

Reviewed and tested locally, all looks good

@girish-lokapure girish-lokapure self-requested a review August 30, 2023 10:18
@officiallygod officiallygod added Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels Aug 30, 2023
@arunshenoy99 arunshenoy99 merged commit 098cf56 into trunk Sep 1, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS-2-1044-Fix-Safari-theme-styles-ordering branch September 1, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girish-lokapure girish-lokapure girish-lokapure approved these changes

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@officiallygod @girish-lokapure @arunshenoy99 @avneet-raj