Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newfold card logo popping up on safari #261

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Jun 23, 2023

This one uses an actual HTML elementdiv with the background instead of ::before.

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label Jun 23, 2023
@arunshenoy99 arunshenoy99 requested a review from Yashita101 June 23, 2023 12:31
Copy link
Contributor

@Yashita101 Yashita101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!
Also tested the same on Mozilla, Chrome, Microsoft Edge for different devices.

@arunshenoy99 arunshenoy99 added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jun 23, 2023
@arunshenoy99 arunshenoy99 merged commit 9dbee16 into trunk Jun 26, 2023
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 26, 2023
@arunshenoy99 arunshenoy99 deleted the hotfix/newfoldcard-logo-on-safari branch June 26, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants