update 2 more svg images with vector graphics only #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brings learn-more-basic-info.svg from 162kb to 41kb brings learn-more-design-homepage.svg from 123kb to 27kb brings us from a total of 285 to 68 a savings of over 200kb
abhijitb
approved these changes
Jun 13, 2023
abhijitb
approved these changes
Jun 13, 2023
officiallygod
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a search for
xlink:href="data:image/png;base64I found 2 more images that are still embedding bitmap data into an svg. This does not take advantage of the scalability of an svg or the file savings even though the image would lend itself well to a vector-based format.These images are:
They were only partially svg graphics - with the window part of the image as a bitmap image even in the figma file. WIth a little time I replaced the bitamp with a similar shape with a gradient and transparency and then reoptimized the images.
This brings the sizes down considerably:
I think we'll be good for now on images. The next thing would be to migrate them to a CDN, but we can discuss if that's worth the effort and management. Note that the images are different sizes and one even the shape changed, so if it messes up where the graphics are displayed it may need a little more attention. I created a new figma for the images at: https://www.figma.com/file/ZDHK4sMeA9OClrMgw26xvV/Untitled?type=design&t=rns16iab5NEuGmro-1
(This is a nice to have but certainly doesn't need to be merged and released before launch.)