Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESS-2 982 | Remove unused images #252

Merged
merged 3 commits into from
Jun 15, 2023
Merged

PRESS-2 982 | Remove unused images #252

merged 3 commits into from
Jun 15, 2023

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Jun 7, 2023 •
edited
Loading

Made Onboarding Lighter:

  • Removed 41 Images ( SVG Files )
  • Optimised Code to reuse images when possible

Reduced Onboarding CSS from 1.18MiB to 1.09Mib ( 7.6% decrease )
Total Onboarding Payload Size from 1.31MiB to 1.22Mib

Before

After

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Jun 7, 2023
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Jun 7, 2023
@officiallygod officiallygod added QA This PR is in QA Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review QA This PR is in QA labels Jun 13, 2023
@arunshenoy99 arunshenoy99 merged commit 93a8354 into trunk Jun 15, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS-2-982-Remove-Unused-Images branch June 15, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yashita101 Yashita101 Yashita101 approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@officiallygod @Yashita101 @arunshenoy99