Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primary site type width and some clamps #247

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Fix primary site type width and some clamps #247

merged 4 commits into from
Jun 5, 2023

Conversation

arunshenoy99
Copy link
Member

No description provided.

@arunshenoy99 arunshenoy99 added the Code Review The PR is in Code Review label May 31, 2023
arunshenoy99
arunshenoy99 commented May 31, 2023
View reviewed changes
Copy link
Member Author

@arunshenoy99 arunshenoy99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed some clamps to be consistent across the flow instead of rapid jumps in sizes based on breakpoints.

Old:

Screenshot 2023-05-31 at 4 50 47 PM

Screenshot 2023-05-31 at 4 51 10 PM

New:

Screenshot 2023-05-31 at 4 52 29 PM

Screenshot 2023-05-31 at 4 55 09 PM

@officiallygod
Copy link
Member

Hey, are we worrying about between 2k and 4k?

scrnli_31_05_2023_13-38-17.mp4

officiallygod
officiallygod approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@officiallygod officiallygod added QA This PR is in QA and removed Code Review The PR is in Code Review labels Jun 1, 2023
@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Jun 5, 2023
@arunshenoy99 arunshenoy99 merged commit 2e1da29 into trunk Jun 5, 2023
@arunshenoy99 arunshenoy99 deleted the bugfix/primary-width branch June 5, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod