removed hard coded slugs from header menu step #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashita101
suggested changes
May 31, 2023
includes/Data/Patterns.php
Outdated
| @@ -99,6 +99,7 @@ protected static function get_theme_step_patterns() { | |||
| 'site-header-left-logo-navigation-inline' => array( | |||
| 'active' => true, | |||
| 'shown' => true, | |||
| 'header' => true, | |||
There was a problem hiding this comment.
Instead of adding a new key check, can we have a callback function? Similar to homepage-styles in get_theme_step_filters ? This way, we would have only the response sent from the backend, and the frontend would display the result based on the header chosen?
Or Can we handle the existence of the key header from here itself?
Basically try to send the maximum response from here with minimum alteration to the response in the frontend.
There was a problem hiding this comment.
This is done. .. thanks
Yashita101
approved these changes
Jun 6, 2023
officiallygod
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.