Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor onboarding to use the installer module #244

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented May 29, 2023

Lint will fail until we can pull a release 1.0.0 from newfold-labs/wp-module-installer

@arunshenoy99 arunshenoy99 added the WIP PR is a Work in Progress and not ready for review. label May 29, 2023
@arunshenoy99 arunshenoy99 added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels May 29, 2023
@avneet-raj
Copy link
Contributor

image image

The Onboarding module is referencing the function from Plugin installer (Inside Bluehost Plugin) which ecommerce module has it in their dependency.

@arunshenoy99 arunshenoy99 merged commit 3a23d72 into trunk Jun 5, 2023
@arunshenoy99 arunshenoy99 deleted the add/installer-module branch June 5, 2023 06:12
@arunshenoy99 arunshenoy99 restored the add/installer-module branch June 5, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants