refactored hard coded logic from homepage menu #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitb
reviewed
May 9, 2023
added 7 commits
May 11, 2023 16:03
arunshenoy99
requested changes
May 17, 2023
arunshenoy99
requested changes
May 18, 2023
There was a problem hiding this comment.
This looks better, thanks @Yashita101, have suggested some more changes, please do take a look.
includes/Data/Patterns.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| protected static function get_theme_step_patterns_callback() { |
There was a problem hiding this comment.
Suggested change
| protected static function get_theme_step_patterns_callback() { | |
| protected static function get_theme_step_filters() { |
includes/Data/Patterns.php
Outdated
Comment on lines
369
to
371
| public static function filter_pattern_data( $pattern_slugs ) { | ||
| return in_array( 'yith-wonder-pages', $pattern_slugs['categories'] ); | ||
| } |
There was a problem hiding this comment.
Can we combine the header and footer identification part with this? Seems like we're going through the entire array anyway with array_filter? Also, this function name can be confusing, I think we should just stick to using a single foreach in get_patterns_for_homepage_menu_slugs to populate the header/footer/homepages instead of array_filter and then a foreach on the remaining elements.
arunshenoy99
approved these changes
May 23, 2023
arunshenoy99
added
QA
arunshenoy99
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.