Split out redirect filters into separate methods #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
login_redirect
filter and thenewfold_sso_success_url
filters accept differing numbers of parameters. They also require different ways of determining the current user. The former does not have$current_user
set and the latter does not have a$user
global variable.To make them both work correctly, and avoid a lot of logic to check values and types of multiple variables, I've created separate methods for each hook that each establish the logged in user, and then pass the url and user on to a single
filter_redirect
method for evaluation.