Replace hex and RGB values #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashita101
suggested changes
Apr 14, 2023
src/OnboardingSPA/components/CheckboxTemplate/CheckboxItem/stylesheet.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Let's hold off on reviewing/making further changes to this until the crazy domains branch gets merged to trunk, we might just have to consolidate a few things for CD as well and ensure that we are on the correct variable names. Not removing the WIP until then.
EDIT: The CD branch is now merged into trunk.
Yashita101
suggested changes
May 3, 2023
src/OnboardingSPA/components/CheckboxTemplate/CheckboxListSkeleton/stylesheet.scss
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/SiteTypeSetup/SecondarySite/stylesheet.scss
Outdated
Show resolved
Hide resolved
src/OnboardingSPA/pages/Steps/GetStarted/Welcome/stylesheet.scss
Outdated
Show resolved
Hide resolved
Yashita101
added
WIP
abhijitb
added
Code Review
Yashita101
suggested changes
May 3, 2023
Yashita101
approved these changes
May 3, 2023
Yashita101
added
QA
since --wp-admin-theme-color-darker-20 is being overridden in different brands we cant use this for the text color in sidebar
arunshenoy99
added
Ready to merge
abhijitb
removed
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.