Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS 2 - 93 | API Queuing System #197

Merged
merged 24 commits into from
Apr 26, 2023
Merged

Conversation

officiallygod
Copy link
Member

No description provided.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Mar 19, 2023
@officiallygod officiallygod removed the WIP PR is a Work in Progress and not ready for review. label Apr 20, 2023
@officiallygod officiallygod added the Ready to merge The Code Review and QA is done and it can be merged. label Apr 25, 2023

await items[ 0 ][ 1 ]()
.then( ( e ) => {
if ( e.error && retryCount < 2 ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ( e.error && retryCount < 2 ) {
if ( e.error && retryCount < 2) {

Should we move 2 to a retry count constant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Done

@arunshenoy99
Copy link
Member

Lint fixes to be handled as part of the fix translations story.

@arunshenoy99 arunshenoy99 merged commit 2044ffa into trunk Apr 26, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS-2-93-API-Queuing-system branch May 25, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants