Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy Header Menu #187

Merged
merged 37 commits into from
Apr 4, 2023
Merged

Dummy Header Menu #187

merged 37 commits into from
Apr 4, 2023

Conversation

abhijitb
Copy link
Contributor

@abhijitb abhijitb commented Mar 2, 2023

These changes make sure that

  1. The number of menu items shown in the live preview are always 6, irrespective of the number of pages or if a navigation menu has been created.
  2. The selected header menu also shows on the next step which is the homepage layout selection.

dummy_header_menu

@abhijitb abhijitb added the WIP PR is a Work in Progress and not ready for review. label Mar 2, 2023
@abhijitb abhijitb removed the WIP PR is a Work in Progress and not ready for review. label Mar 2, 2023
arunshenoy99
arunshenoy99 reviewed Mar 13, 2023
View reviewed changes
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
arunshenoy99
arunshenoy99 requested changes Mar 13, 2023
View reviewed changes
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
includes/WP_Admin.php Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/DrawerPanel/DesignHeaderMenu.js Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/stylesheet.scss Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/stylesheet.scss Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/stylesheet.scss Outdated Show resolved Hide resolved
officiallygod
officiallygod approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arunshenoy99
arunshenoy99 requested changes Mar 20, 2023
View reviewed changes
includes/Application.php Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/RestApi/Themes/PatternsController.php Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignColors/index.js Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
arunshenoy99
arunshenoy99 requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @abhijitb, some minor things to take care of, after which we can get this merged.

includes/Data/Patterns.php Outdated Show resolved Hide resolved
includes/Data/Patterns.php Outdated Show resolved Hide resolved
src/OnboardingSPA/components/Drawer/DrawerPanel/DesignThemeStylesPreview.js Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignColors/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignHomepageMenu/index.js Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignThemeStyles/Menu/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignThemeStyles/Preview/index.js Outdated Show resolved Hide resolved
src/OnboardingSPA/pages/Steps/DesignTypography/index.js Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 merged commit cab49b2 into trunk Apr 4, 2023
@arunshenoy99 arunshenoy99 deleted the enhance/PRESS2-399-dummy-menu branch April 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhijitb @arunshenoy99 @officiallygod