Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin status detection #183

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

arunshenoy99
Copy link
Member

When plugin installation is in progress via the WP_Cron and the plugin directory is in a half-baked state, Onboarding is unable to determine if the plugin has been installed or not, causing it to default to a not installed state. This PR checks if a plugin is being installed and then waits for the installation task to complete before defaulting to the not installed state.

@avneet-raj
Copy link
Contributor

Tested on my local for these 3 scenarios:

  1. When we go very fast ecom step. Sometimes the woocommerce plugin gets installed and activated within time i.e 30sec but sometimes it gets only installed and not activated and then we refresh the page the plugin gets activated and then we are good to go.
  2. When we go with normal approach with selecting every elements to the ecom steps, after 30 sec wait the plugin gets activated and we can move ahead.
  3. When the woocommerce plugin is already there and activated, then there is no wait for 30 sec for the ecom step to load.

@arunshenoy99 arunshenoy99 merged commit 5d2f5c0 into trunk Feb 24, 2023
@arunshenoy99 arunshenoy99 deleted the fix/improve-plugin-status-detection branch February 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants