Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings api - tiktok and yelp url fixes #169

Merged
merged 6 commits into from
Feb 8, 2023

Conversation

abhijitb
Copy link
Contributor

@abhijitb abhijitb commented Feb 6, 2023

No description provided.

@abhijitb abhijitb added the Post Phase 2 Polish Polish PR's for work done in Phase 2 label Feb 6, 2023
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abhijitb did a quick test before reviewing all of the code, I seem to always be in either of these 2 conditions both of which do not clear the yelp/tiktok URL's.

  1. A mastodon_url has appeared causing the API to fail (only when Yoast is active) ss-1
  2. Request:
    ss-2
    Response:
    ss-3

includes/RestApi/SettingsController.php Outdated Show resolved Hide resolved
@arunshenoy99 arunshenoy99 merged commit 8c90766 into trunk Feb 8, 2023
@arunshenoy99 arunshenoy99 deleted the PRESS2-551-settings-api-tiktok-yelp-fix branch February 8, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants