Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DesignStateHandler to allow switching back to Wonder via a confirmation dialog #155

Merged
merged 9 commits into from
Feb 8, 2023

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Jan 23, 2023

  1. Allows switching back via dialog when user re-visits onboarding and does not have Wonder active.
  2. Allows switching back via dialog when user re-visits the design steps via drawer/header-navigation after generating the child theme.
  3. Prevents unnecessary API calls in the error state.

@arunshenoy99 arunshenoy99 added the Post Phase 2 Polish Polish PR's for work done in Phase 2 label Jan 23, 2023
@arunshenoy99
Copy link
Member Author

screen-capture.mp4

@avneet-raj
Copy link
Contributor

https://paste.pics/86f6b65748bbcf180403c394e9a815c6

Hi @arunshenoy99 , according to the description we have options for YES and Exit to Wordpress. But here it is continue.

@avneet-raj
Copy link
Contributor

Untitled.mp4

when we change the theme from admin dashboard and then try to change the theme style without refreshing the page, it gives something like this.
https://paste.pics/d5d5a922dd7f4658e11d95579405ab9a

@arunshenoy99 arunshenoy99 merged commit ab51ec4 into trunk Feb 8, 2023
@arunshenoy99 arunshenoy99 deleted the add/PRESS2-443-allow-switching-back-to-wonder branch February 8, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants