Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to customer data if flow param/option does not exist #153

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

arunshenoy99
Copy link
Member

No description provided.

@@ -10,89 +10,88 @@

/**
* Class ModuleController
*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in includes/ModuleController.php other than the formatting are

  • Switch from date to gmdate, phpcs found a code standards violation date() is affected by runtime timezone changes which can cause date/time to be| incorrectly displayed. Use gmdate() instead.
  • Use the is_ecommerce_plan function

@arunshenoy99 arunshenoy99 changed the title Module - Fallback to customer data if flow param/option does not exist Fallback to customer data if flow param/option does not exist Jan 16, 2023
@arunshenoy99 arunshenoy99 added bug Something isn't working Post Phase 2 Polish Polish PR's for work done in Phase 2 labels Jan 16, 2023
@arunshenoy99 arunshenoy99 merged commit a4b230d into trunk Jan 17, 2023
@arunshenoy99 arunshenoy99 deleted the fix/flow-param-fallback branch January 17, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Post Phase 2 Polish Polish PR's for work done in Phase 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants