Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP code linting #150

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add PHP code linting #150

merged 1 commit into from
Jan 12, 2023

Conversation

wpscholar
Copy link
Member

Proper code linting would have prevented the issue with the trailing commas. As such, this PR adds linting.

You'll need to run composer install and then composer run lint locally. The linting will run for changed PHP files on GitHub Actions.

@wpscholar wpscholar self-assigned this Jan 10, 2023
@wpscholar wpscholar added the enhancement New feature or request label Jan 10, 2023
@wpscholar wpscholar mentioned this pull request Jan 10, 2023
Closed
@arunshenoy99
Copy link
Member

Thanks @wpscholar

@arunshenoy99 arunshenoy99 merged commit 5bdb1ec into trunk Jan 12, 2023
@arunshenoy99 arunshenoy99 deleted the add/linting branch January 12, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@wpscholar wpscholar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpscholar @arunshenoy99