-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Info FadeIn State #146
Basic Info FadeIn State #146
Conversation
…d/PRESS2-466-Skeleton-State-Basic-Info
Let's wait for PRESS 2-462 to be merged before we merge this Story, as this has changes from that story. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending: Investigate if we can wait on the site logo to load as well instead of waiting only on flow and social API's
Also, made changes to PRESS 2-462 to use an Animate component, please do make the changes accordingly and do provide any feedback or changes that further need to be made. |
…ress-Step-Ecommerce' into add/PRESS2-466-Skeleton-State-Basic-Info
The rendering of the image of the user depends on their internet speed, which is not possible to track via our code, as we can verify if the url is valid and not whether the rendering is complete. Hence this condition for siteLogo cannot be checked. |
Have some idea around tracking, will create a new story. |
…oarding into add/PRESS2-466-Skeleton-State-Basic-Info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yashita101 I just merged trunk
into this branch to get a good idea of the changes and noticed something: can we please remove all the changes in src/OnboardingSPA/pages/Steps/Ecommerce/StepAddress/index.js
? This change deletes Animate
from StepAddress
and we definitely need Animate
in our address step.
…thub.com/newfold-labs/wp-module-onboarding into add/PRESS2-466-Skeleton-State-Basic-Info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will create a story with details to handle the site logo render.
No description provided.