Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Site Title: Hashed Child Theme slug #135

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

arunshenoy99
Copy link
Member

No description provided.

@arunshenoy99 arunshenoy99 added the WIP PR is a Work in Progress and not ready for review. label Dec 12, 2022
@arunshenoy99 arunshenoy99 removed the WIP PR is a Work in Progress and not ready for review. label Dec 12, 2022
Copy link
Member

@0aveRyan 0aveRyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is exactly what I was envisioning by hashing the site url. Unique per-site on account, overwhelmingly likely unique per-site on box and likely unique across farm.

This is only when folks don't name a site. Which is the edge case. I think we're well covered!

@arunshenoy99 arunshenoy99 merged commit 2881f9a into release/v1.0.0 Dec 12, 2022
@arunshenoy99 arunshenoy99 deleted the add/PRESS2-415-no-site-title-child-theme branch December 12, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants