Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Step Polish & Add What's Next MVP #129

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

0aveRyan
Copy link
Member

  • Updates images used in Welcome tabs
  • Light style updates to welcome
  • Port over to what's next with content
  • Add animation polish

@0aveRyan 0aveRyan changed the title Add/welcome whats next enhancements Welcome Step Polish & Add What's Next MVP Dec 11, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0aveRyan have you missed pushing changes to src/OnboardingSPA/pages/Steps/WhatNext/index.js I still see the old design.

@0aveRyan
Copy link
Member Author

@0aveRyan have you missed pushing changes to src/OnboardingSPA/pages/Steps/WhatNext/index.js I still see the old design.

I don't know how that one file didn't make it, it kept showing on my local. Had to delete branch locally and clone this while keeping source in clipboard.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed changes to

  1. Disable the back navigation button on what next to prevent users from entering an error state by going back to "complete", users can still navigate via the drawer to other steps
  2. Make the Complete Setup work to exit onboarding.
    @0aveRyan please do confirm after which I will merge this.

@officiallygod
Copy link
Member

Hey @0aveRyan maybe we can have a story in later so as to remove this duplicate CSS from WhatNext> stylesheet.scss as this same thing exists in GetStarted>Welcome>stylesheet.scss
Maybe in the future if we make changes here that will reflect on other pages too cause class names are the same.

@arunshenoy99 arunshenoy99 merged commit 12e4ff2 into release/v1.0.0 Dec 13, 2022
@arunshenoy99 arunshenoy99 deleted the add/welcome-whats-next-enhancements branch December 13, 2022 14:02
@0aveRyan
Copy link
Member Author

@officiallygod absolutely, I want to prioritize a list of fast follow items for jan 4. I'll post more in teams but let's identify everything and decide on priorities Thursday! But that was always my intention was to get some code reuse with a cleanup and have a story for one of you to architect it considerate of the rest of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants