-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome Step Polish & Add What's Next MVP #129
Welcome Step Polish & Add What's Next MVP #129
Conversation
0aveRyan
commented
Dec 11, 2022
- Updates images used in Welcome tabs
- Light style updates to welcome
- Port over to what's next with content
- Add animation polish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0aveRyan have you missed pushing changes to src/OnboardingSPA/pages/Steps/WhatNext/index.js
I still see the old design.
I don't know how that one file didn't make it, it kept showing on my local. Had to delete branch locally and clone this while keeping source in clipboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed changes to
- Disable the back navigation button on what next to prevent users from entering an error state by going back to "complete", users can still navigate via the drawer to other steps
- Make the
Complete Setup
work to exit onboarding.
@0aveRyan please do confirm after which I will merge this.
…odule-onboarding into add/welcome-whats-next-enhancements
Hey @0aveRyan maybe we can have a story in later so as to remove this duplicate CSS from WhatNext> stylesheet.scss as this same thing exists in GetStarted>Welcome>stylesheet.scss |
@officiallygod absolutely, I want to prioritize a list of fast follow items for jan 4. I'll post more in teams but let's identify everything and decide on priorities Thursday! But that was always my intention was to get some code reuse with a cleanup and have a story for one of you to architect it considerate of the rest of the project. |