Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no-title Page Template on wp_insert_post for Homepage #128

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

0aveRyan
Copy link
Member

@0aveRyan 0aveRyan commented Dec 11, 2022

Notes:

  • no-title maps to the Page Template available in the YITH Wonder theme.

Currently when Onboarding is injecting posts they're all getting the standard Template. This creates a disconnect between Live Previews we generate correctly in Onboarding, but how content renders in Page templates from the Block Theme.

I've aimed to leave this open to other future template declarations that I know we'll need to have capabilities for.

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed small changes to

  1. Remove array which does not have page_template and use the $post variable.
  2. Make function accept $is_template_no_title instead of checking titles.

@0aveRyan please confirm if these look good.

@0aveRyan
Copy link
Member Author

@arunshenoy99 Thanks!

@arunshenoy99 arunshenoy99 merged commit f1ca494 into release/v1.0.0 Dec 12, 2022
@arunshenoy99 arunshenoy99 deleted the fix/homepage-page-template branch December 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants