Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YITH Wonder Palettes #127

Merged
merged 8 commits into from
Dec 13, 2022

Conversation

0aveRyan
Copy link
Member

@0aveRyan 0aveRyan commented Dec 11, 2022

  • Expands Onboarding palettes from Figma with full-spectrum custom palettes used by YITH Wonder to create custom designs.
  • Adds YITH Wonder color palette support to Live Previews when Onboarding palettes are selected.
  • Adds a few more palettes for launch.

@0aveRyan 0aveRyan added the WIP PR is a Work in Progress and not ready for review. label Dec 11, 2022
@0aveRyan 0aveRyan removed the WIP PR is a Work in Progress and not ready for review. label Dec 12, 2022
@0aveRyan 0aveRyan requested a review from Yashita101 December 12, 2022 02:10
@officiallygod
Copy link
Member

Hey I was testing this out and I saw that once the user selects a Custom Background Color Option then selects one of the options made by us the bg color is retained, so maybe we can add 'background' => '#FFFFFF', instead of empty for all predefined styles in includes/Data/Themes/Colors.php?

@officiallygod
Copy link
Member

Also had been wondering that in these predefined colors every color has a very subtle secondary color and I think that it is barely readable in any of the Predefined Color Palettes. Maybe we can Look into this?

207008760-a189ba74-d16f-4844-aa53-99aacd19b0b0

@0aveRyan
Copy link
Member Author

0aveRyan commented Dec 12, 2022

@officiallygod

Hey I was testing this out and I saw that once the user selects a Custom Background Color Option then selects one of the options made by us the bg color is retained, so maybe we can add 'background' => '#FFFFFF', instead of empty for all predefined styles in includes/Data/Themes/Colors.php?

Let's go with 'background' => '#FFFFFF

On subtle secondaries

Something we need to explore and refine. EDIT: I've seen what you're pointing out now, thinking about the best short-term and long-term solutions.

@arunshenoy99 arunshenoy99 mentioned this pull request Dec 12, 2022
@0aveRyan
Copy link
Member Author

@officiallygod got you new color palettes I think will resolve our issues for launch

@officiallygod
Copy link
Member

@officiallygod got you new color palettes I think will resolve our issues for launch

Sure @0aveRyan Thanks!

@arunshenoy99 arunshenoy99 merged commit 59858df into release/v1.0.0 Dec 13, 2022
@arunshenoy99 arunshenoy99 deleted the add/yith-wonder-color-palettes branch December 13, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants