Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS 2 359 Call Site Features API in the Theme Generation interstitial state #116

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Dec 8, 2022

This Calls the Site Features API to queue/enqueue all the Installs and Uninstalls of various plugins according to the choices made by the user.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Dec 8, 2022
@officiallygod officiallygod removed the WIP PR is a Work in Progress and not ready for review. label Dec 8, 2022
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.webm
Attaching SC, whenever I click next after site-features I immediately get what-next or get a blank what-next page but never get the loading state. The API calls work which probably means we need to await on them to complete.

@officiallygod
Copy link
Member Author

Ohhooo Lemme see that!

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I found, I de-selected jetpack from the list when it was still in the install_queue but it was still added to the uninstall_queue, we should never add to the uninstall_queue if it was never installed in the first place, attaching SS
Screenshot 2022-12-12 at 11 07 45 AM

Screenshot 2022-12-12 at 11 07 33 AM

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In one case when I went back via the drawer back to site-features and re-selected jetpack, it was added to the install queue but was immediately removed and was never installed, can you please check this as well?

@arunshenoy99 arunshenoy99 merged commit aa9d3c2 into release/v1.0.0 Dec 12, 2022
@arunshenoy99 arunshenoy99 deleted the PRESS-2-359-Call-Site-Features-API-in-the-Theme-Generation-Interstitial-State branch December 12, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants