Add/theme header menu #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, we can run Lint |
|
Also, the first time I opened the Header page directly after deleting flow from DB, it crashed! Then on a refresh, it was fine. IDKY |
|
Also, can we limit the Links shown in the header as we sometimes have a lot of them and they don't look appealing. |
officiallygod
approved these changes
Dec 7, 2022
|
There is a delay for me on the Header Menu page before anything shows up and that was fixed for other steps with LivePreviewSkeleton component not the default skeleton inside LivePreview, Maybe can we use that and inline the number of previews? To be addressed as a part of the Header Dummy Menu story. |
arunshenoy99
reviewed
Dec 7, 2022
includes/Data/Patterns.php
Outdated
Comment on lines
75
to
83
| 'header-menu' => array( | ||
| 'site-header-left-logo-navigation-inline' => array( | ||
| 'active' => true, | ||
| 'shown' => true, | ||
| ), | ||
| 'homepage-1' => array( | ||
| 'active' => true, | ||
| ), | ||
| 'site-footer' => array( |
There was a problem hiding this comment.
The formatting doesn't look right here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.