Merge pull request #351 from newfold-labs/hotfix/react-warning

Fix React Warning for `onKeyDown`
newfold-labs · Nov 1, 2023 · fd737a1 · fd737a1
2 parents 385f93e + 7f7af19
commit fd737a1
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/src/OnboardingSPA/components/LivePreview/SelectableCard/index.js b/src/OnboardingSPA/components/LivePreview/SelectableCard/index.js
@@ -21,22 +21,16 @@ const SelectableCard = ( {
 			className={ `${ className }` }
 			role="button"
 			tabIndex={ 0 }
-			onClick={
-				typeof onClick === 'function' &&
-				( () => {
-					if ( ! loadingParent ) {
-						onClick();
-					}
-				} )
-			}
-			onKeyDown={
-				typeof onClick === 'function' &&
-				( () => {
-					if ( ! loadingParent ) {
-						onClick();
-					}
-				} )
-			}
+			onClick={ () => {
+				if ( ! loadingParent && typeof onClick === 'function' ) {
+					onClick();
+				}
+			} }
+			onKeyDown={ () => {
+				if ( ! loadingParent && typeof onClick === 'function' ) {
+					onClick();
+				}
+			} }
 		>
 			<div className={ `${ className }__title-bar` }>
 				<div className={ `${ className }__title-bar__browser` }>