Sitegen: Fix Site Logo Data #1741
lint-check-spa.yml
on: pull_request
Run Lint Checks
23s
Annotations
2 warnings
Run Lint Checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3, technote-space/get-diff-action@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js#L70
React Hook useEffect has missing dependencies: 'currentData.sitegen.siteLogo', 'getEditedEntityRecord', 'setDrawerActiveView', 'setHeaderActiveView', 'setHideFooterNav', 'setIsFooterNavAllowed', 'setIsHeaderEnabled', 'setIsHeaderNavigationEnabled', and 'setSidebarActiveView'. Either include them or remove the dependency array
|