Merge pull request #471 from newfold-labs/fixes-some-minor-issues-in-… #1689
Annotations
10 warnings
Run Lint Checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3, technote-space/get-diff-action@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/Editor/index.js#L65
React Hook useEffect has missing dependencies: 'handleSitemapPagesGeneration', 'loadData', 'setDrawerActiveView', 'setHeaderActiveView', and 'setIsHeaderEnabled'. Either include them or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/Experience/index.js#L34
React Hook useEffect contains a call to 'setSelection'. Without a list of dependencies, this can lead to an infinite chain of updates. To fix this, pass [setHideFooterNav, setIsHeaderEnabled, setSidebarActiveView, setIsHeaderNavigationEnabled, setHeaderActiveView, setDrawerActiveView, currentData.sitegen.experience.level] as a second argument to the useEffect Hook
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/Preview/index.js#L60
React Hook useEffect has missing dependencies: 'setDrawerActiveView', 'setHeaderActiveView', 'setHideFooterNav', 'setIsHeaderEnabled', 'setIsHeaderNavigationEnabled', 'setSidebarActiveView', and 'updateInitialize'. Either include them or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/Preview/index.js#L71
React Hook useEffect has a missing dependency: 'loadHomepages'. Either include it or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/Preview/index.js#L113
React Hook useEffect has a missing dependency: 'loadHomepages'. Either include it or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/SiteDetails/index.js#L51
React Hook useEffect has missing dependencies: 'currentData.sitegen.siteDetails.prompt', 'setDrawerActiveView', 'setHeaderActiveView', 'setHideFooterNav', 'setIsFooterNavAllowed', 'setIsHeaderEnabled', 'setIsHeaderNavigationEnabled', and 'setSidebarActiveView'. Either include them or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/SiteDetails/index.js#L66
React Hook useEffect has missing dependencies: 'currentData', 'isValidInput', 'setCurrentOnboardingData', and 'setIsFooterNavAllowed'. Either include them or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js#L70
React Hook useEffect has missing dependencies: 'currentData.data.siteLogo', 'getEditedEntityRecord', 'setDrawerActiveView', 'setHeaderActiveView', 'setHideFooterNav', 'setIsFooterNavAllowed', 'setIsHeaderEnabled', 'setIsHeaderNavigationEnabled', and 'setSidebarActiveView'. Either include them or remove the dependency array
|
Run Lint Checks:
src/OnboardingSPA/steps/SiteGen/SocialMedia/index.js#L59
React Hook useEffect has missing dependencies: 'navigate', 'nextStep.path', and 'setIsFooterNavAllowed'. Either include them or remove the dependency array
|