Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Module Support for Translations and Include Relevant pt_BR Translations #72

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

  1. Adds translation support for non-toggleable modules.
  2. Transferred relevant translations from Onboarding to this module.

@officiallygod officiallygod added QA Ready for QA and removed Code Review Code Review labels Apr 19, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Apr 29, 2024
@arunshenoy99 arunshenoy99 merged commit b7c1a88 into main Apr 29, 2024
@arunshenoy99 arunshenoy99 deleted the add/pt_BR-translations branch April 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants