Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isFreshInstallation to data #71

Merged
merged 3 commits into from
May 2, 2024
Merged

Add isFreshInstallation to data #71

merged 3 commits into from
May 2, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 mentioned this pull request Apr 12, 2024
Merged
8 tasks
@arunshenoy99 arunshenoy99 added the Code Review Code Review label Apr 12, 2024
officiallygod
officiallygod approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@officiallygod officiallygod added QA Ready for QA and removed Code Review Code Review labels Apr 26, 2024
@arunshenoy99 arunshenoy99 mentioned this pull request May 2, 2024
Merged
8 tasks
officiallygod
officiallygod approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Done, Looks Good to me.

@arunshenoy99 arunshenoy99 merged commit c32d6f7 into main May 2, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the add/data-is-fresh-install branch May 2, 2024 08:53
@arunshenoy99 arunshenoy99 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod