Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress dalle image size #62

Merged
merged 15 commits into from
Apr 5, 2024
Merged

Compress dalle image size #62

merged 15 commits into from
Apr 5, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Mar 13, 2024 •
edited
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Screenshot 2024-03-13 at 12 33 52 PM Screenshot 2024-03-13 at 12 36 00 PM

@ajayadav09 ajayadav09 self-assigned this Mar 13, 2024
@ajayadav09 ajayadav09 added the In Progress The Development is currently going on. label Mar 13, 2024
@ajayadav09 ajayadav09 marked this pull request as ready for review March 20, 2024 06:56
@ajayadav09 ajayadav09 added Code Review Code Review and removed In Progress The Development is currently going on. labels Mar 20, 2024
officiallygod
officiallygod reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small concerns.

includes/Services/SiteGenService.php Outdated Show resolved Hide resolved
includes/Services/SiteGenService.php Show resolved Hide resolved
includes/Services/SiteGenService.php Outdated Show resolved Hide resolved
officiallygod
officiallygod reviewed Apr 3, 2024
View reviewed changes
includes/Services/SiteGenService.php Outdated Show resolved Hide resolved
includes/Services/SiteGenService.php Outdated Show resolved Hide resolved
officiallygod
officiallygod reviewed Apr 4, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@ajayadav09 ajayadav09 requested a review from officiallygod April 4, 2024 17:14
officiallygod
officiallygod approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good for QA

@officiallygod officiallygod added QA Ready for QA and removed Code Review Code Review labels Apr 5, 2024
@sangeetha-nayak
Copy link

LGTM

@ajayadav09 ajayadav09 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Apr 5, 2024
@ajayadav09 ajayadav09 merged commit 07ec27e into main Apr 5, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the compress-dalle-image-size branch September 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees

@ajayadav09 ajayadav09

Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajayadav09 @sangeetha-nayak @officiallygod